src/components/homepage/legacy-escrow-banner.module.css (1)

8-24: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚖️ Poor tradeoff

Magic-number coupling to hero-section.module.css breakpoints.

The negative margin-top values and breakpoints are hand-copied to mirror another file's layout, per the comment. Any future change to hero padding/breakpoints silently desyncs this file since there's no shared constant/variable enforcing the relationship.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/homepage/legacy-escrow-banner.module.css` around lines 8 - 24,
The banner spacing in the legacy escrow CSS is hard-coupled to hero-section
layout values via copied breakpoints and negative margins. Refactor the .banner
rules to use shared design tokens or CSS custom properties sourced from the hero
layout, and update the `@media` thresholds to reference the same centralized
values so both files stay in sync. Use the existing .banner selector and the
hero-section.module.css breakpoint/padding definitions as the single source of
truth.

src/components/homepage/legacy-escrow-banner.tsx (1)

20-31: 🩺 Stability & Availability | 🔵 Trivial | 💤 Low value

Guard localStorage access against exceptions.

localStorage.getItem/setItem are called unguarded. In restrictive environments (e.g., private browsing modes, storage disabled by policy), these calls can throw and crash the component since there's no error boundary/try-catch here.

🛡️ Proposed defensive fix

   useEffect(() => {
-    setVisible(localStorage.getItem(DISMISSED_KEY) !== 'true');
+    try {
+      setVisible(localStorage.getItem(DISMISSED_KEY) !== 'true');
+    } catch {
+      setVisible(true);
+    }
   }, []);

   const dismiss = () => {
-    localStorage.setItem(DISMISSED_KEY, 'true');
-    setVisible(false);
+    try {
+      localStorage.setItem(DISMISSED_KEY, 'true');
+    } catch {
+      // ignore storage errors; still hide for this session
+    }
+    setVisible(false);
   };

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/homepage/legacy-escrow-banner.tsx` around lines 20 - 31, The
localStorage calls in LegacyEscrowBanner are unguarded and can throw in
restricted environments. Update the useEffect initializer and the dismiss
handler to wrap localStorage.getItem and localStorage.setItem in defensive
try/catch logic, and fall back to a safe default if storage is unavailable. Keep
the fix localized to LegacyEscrowBanner and its dismiss function so the
component still renders without crashing when storage access fails.

src/components/homepage/hero-section.module.css (2)

72-84: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Magic numbers duplicate hero's nav-overlap geometry.

-80px/-90px/-120px mirror .root's --nav-overlap and its own breakpoint overrides but aren't derived from them. If the hero's overlap or padding changes, these values will silently drift out of sync.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/homepage/hero-section.module.css` around lines 72 - 84, The
.legacyEscrowBanner spacing is hard-coded with magic numbers that duplicate the
hero nav-overlap values and can drift from .root. Update the
hero-section.module.css rules for .legacyEscrowBanner to derive its negative
margin from the same --nav-overlap geometry used by .root, preferably via a
shared CSS variable or calc() expression across the matching media breakpoints,
so the banner stays in sync if the hero overlap changes.

---

72-86: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Reuse the hero overlap offset here
The margin-top values here duplicate the hero’s breakpoint-specific nav overlap. Pull this from the same custom property or shared rule so the banner stays aligned if the hero spacing changes.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/homepage/hero-section.module.css` around lines 72 - 86, The
.legacyEscrowBanner margin-top values are duplicating the hero’s
breakpoint-specific overlap spacing, so update this rule to reuse the same
shared custom property or overlapping spacing source used by the hero section.
Keep the existing breakpoint behavior in sync by referencing the shared hero
offset in hero-section.module.css rather than hardcoding separate values here.